Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graft source files in manifest #155

Merged
merged 1 commit into from
Jul 30, 2024
Merged

graft source files in manifest #155

merged 1 commit into from
Jul 30, 2024

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Jul 30, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

The conda feedstock is failing: conda-forge/brainrender-napari-feedstock#2

What does this PR do?

Grafts the source Python files in the manifest

References

/

How has this PR been tested?

It hasn't 😬 Discussions with @willGraham01 make me believe this should fix the "Packages found in the meta.yaml but not found by source code inspection:" problem on conda, but we will have to see. If anyone has more knowledge.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

  • [n/a] The code has been tested locally
  • [n/a] Tests have been added to cover all new functionality (unit & integration)
  • [n/a] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder self-assigned this Jul 30, 2024
@alessandrofelder alessandrofelder requested a review from a team July 30, 2024 16:07
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (763e4b3) to head (7179b46).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files          11       11           
  Lines         464      464           
=======================================
  Hits          455      455           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamltyson
Copy link
Member

adamltyson commented Jul 30, 2024

I'm not sure this is the fix to the problem. The Azure CI is failing because brainglobe-utils isn't in the recipe file. Updating the conda dependencies should fix it.

@alessandrofelder
Copy link
Member Author

alessandrofelder commented Jul 30, 2024

Yes, but I think that's a separate problem from the one I am trying to solve here?
There are two things the conda-bot code analysis is complaining about, IIUC (I may not!).
I'll open a separate PR adding utils to pyproject.toml meta.yaml?

@adamltyson
Copy link
Member

Ah, your comment mentioned conda "failing", so I assumed that was the aim of this PR. The comments from the bot are just some static analysis, they're not necessarily related to why the build is failing. Anyway, I'll approve this, as it's nice to make the warnings go away.

@adamltyson adamltyson merged commit 7cc7e9b into main Jul 30, 2024
13 checks passed
@adamltyson adamltyson deleted the fix-manifest-for-conda branch July 30, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants