Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display atlas images and meshes in pixel space #160

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Sep 25, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
To work well with other Brainglobe napari plugins, brainrender-napari should display things in pixel space. It would be nice to have this in before the teaching next week, for demo purposes.

What does this PR do?
Modifies the napari atlas representation class so it downscales the meshes to pixels, instead of upscaling the images to microns.

References

closes #140 .

How has this PR been tested?

Existing tests pass, (bar some connectivity issues on CI I think)

Is this a breaking change?

Yes, this plugin now works differently.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (c69dd91) to head (7a031fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files          11       11           
  Lines         464      465    +1     
=======================================
+ Hits          455      456    +1     
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder alessandrofelder marked this pull request as ready for review September 30, 2024 13:34
@alessandrofelder alessandrofelder requested a review from a team September 30, 2024 13:55
Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely!

@adamltyson
Copy link
Member

Are there any docs that need updating?

@adamltyson adamltyson merged commit cbc93b8 into main Sep 30, 2024
11 of 13 checks passed
@adamltyson adamltyson deleted the to-pixel-scale branch September 30, 2024 15:10
@alessandrofelder
Copy link
Member Author

Are there any docs that need updating?

I think not

  • docstrings updated as part of this PR
  • tutorial makes no mention of the absolute scale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scale meshes to image data
2 participants