Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly load neuron via morphio before passing to neuromorph #84

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

IgorTatarnikov
Copy link
Member

@IgorTatarnikov IgorTatarnikov commented Nov 8, 2024

Allows swc files with UNIFURCATED_SECTION_CHANGE to be loaded.

See https://morphio.readthedocs.io/en/latest/morphology.html and https://neurom.readthedocs.io/en/stable/migration.html for other migration concerns I may have missed.

Closes #83

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.14%. Comparing base (42a9945) to head (fc11f74).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   70.95%   72.14%   +1.18%     
==========================================
  Files          10       10              
  Lines         699      718      +19     
==========================================
+ Hits          496      518      +22     
+ Misses        203      200       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IgorTatarnikov IgorTatarnikov marked this pull request as ready for review November 11, 2024 10:39
@IgorTatarnikov IgorTatarnikov requested a review from a team November 11, 2024 10:40
@alessandrofelder alessandrofelder merged commit 437e0bc into main Nov 11, 2024
24 checks passed
@IgorTatarnikov IgorTatarnikov deleted the morphio_fix branch November 11, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants