-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow llmClient to be optionally passed in #352
allow llmClient to be optionally passed in #352
Conversation
this looks great! can we add an example of how to use a custom client (like in #349 with ollama/llama 3.2) in we also need to work towards a fast-follow PR that can allow a user to pass in a custom |
#349 now proposes an example ollama client which extends the |
Perfect, I think both look good -- can we add #349 here as follows:
This way, we can more easily clone the branch and make sure nothing else is breaking. tysm 🙇 🙏 |
Also, please add a changeset ( |
🦋 Changeset detectedLatest commit: 0495898 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hell yeah! merging into an evals branch to make sure we're not missing anything
projectId: process.env.BROWSERBASE_PROJECT_ID, | ||
verbose: 1, | ||
llmClient: new OllamaClient( | ||
(message: LogLine) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for future PR: we should make LLMClient
default inherit logger from Stagehand so we don't have to do this
* allow llmClient to be optionally passed in (#352) * feat: allow llmClient to be optionally passed in * update: add ollama client example from pr: #349 * update: README and changeset * lint --------- Co-authored-by: Arihan Varanasi <[email protected]>
why
Allow users to easily define their own llm clients rather than adding support for each major provider in the main codebase #350
what changed
Added
llmClient
toStagehand
constructor so that custom clients can be passed in