Feat rule platform modulename #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 17, 2019 10:18
Allows running mocha on the command line
Avoids the need to run babel-node directly. Allows calling `mocha test/rules/<test.spec>` directly.
Also includes line and column checking in the errors.
https://aurelia.io/docs/build-systems/webpack/a-basic-example#platformmodulename Has different places the rule will apply, separating these checks makes testing these simpler.
context is going to be necessary, along with state. Without mucking around with classes inlining is the easiest way to close over that state.
This adds correct handling of exported configure function and checking the parameter name aurelia matches.
Enabling turns on debug output for the rule.
added 26 commits
July 19, 2019 11:00
…duleName to use generated call name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also cleans up the webpack config feature a bit when refactorings were done.