Use libblockdev instead of pycryptsetup #162
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryptsetup 2.0.6 deprecated pycryptsetup, and it has been removed from version 2.1.0. All the functionality needed for ister is available in libblockdev, so make it use that instead. This has not been tested. It's just a RFC. Signed-off-by: Leandro Pereira <[email protected]>
bryteise
reviewed
Apr 16, 2019
| import pycryptsetup | ||
| import gi | ||
| gi.require_version("BlockDev", "2.0") | ||
| from gi.repository import BlockDev as bd |
There was a problem hiding this comment.
Oh fun, gobject introspection. Well I guess that's making good use of the gnome stack.
|
Looks fine to me. Everything seems to make sense. I wonder though if we could fail earlier in case of errors in the two new calls for setting up LUKS? I'm not really bothered by this behavior though as it would still fail eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cryptsetup 2.0.6 deprecated pycryptsetup, and it has been removed from
version 2.1.0. All the functionality needed for ister is available in
libblockdev, so make it use that instead.
This has not been tested. It's just a RFC.
Signed-off-by: Leandro Pereira [email protected]