Skip to content

Commit

Permalink
Remove PHP 8.4 deprecations and update test matrices (#547)
Browse files Browse the repository at this point in the history
* Use dev version of bugsnag-php for tests

* Use in dev version of the PSR logger

* Remove nullable type annotations from method signatures

* Remove test dependency setup
  • Loading branch information
Cawllec authored Dec 17, 2024
1 parent 257e862 commit 144c95a
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/maze-runner-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ jobs:
laravel-fixture: laravel10
- php-version: '8.3'
laravel-fixture: laravel11
- php-version: '8.4'
laravel-fixture: laravel11
- php-version: '8.0'
laravel-fixture: lumen8

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ jobs:
laravel-version: '10.*'
- php-version: '8.3'
laravel-version: '11.*'
- php-version: '8.4'
laravel-version: '11.*'

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion src/LaravelLogger.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class LaravelLogger extends BugsnagLogger implements Log
*
* @return void
*/
public function __construct(Client $client, Dispatcher $dispatcher = null)
public function __construct(Client $client, $dispatcher = null)
{
parent::__construct($client);

Expand Down
2 changes: 1 addition & 1 deletion src/MultiLogger.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class MultiLogger extends BaseLogger implements Log
*
* @return void
*/
public function __construct(array $loggers, Dispatcher $dispatcher = null)
public function __construct(array $loggers, $dispatcher = null)
{
parent::__construct($loggers);

Expand Down

0 comments on commit 144c95a

Please sign in to comment.