Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always test in race mode #2096

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Always test in race mode #2096

wants to merge 1 commit into from

Conversation

moskyb
Copy link
Contributor

@moskyb moskyb commented May 18, 2023

We currently have one step in CI for running the tests in race mode, but it only runs those race tests against the linux-arm64 target.

We originally added the one race test because there were certain tests that we knew contained data races, and wanted to be able to skip them only in race mode. Now though, i think we've resolved all of those data races (largely due to @DrJosh9000's amazing work 🎉), so we should just always test in race mode.

@moskyb moskyb force-pushed the always-race-test branch from 4eb2aa5 to 634200b Compare May 18, 2023 03:01
@moskyb
Copy link
Contributor Author

moskyb commented May 18, 2023

turns out -race requires CGO, which requires gcc to be installed on the machine, which won't work for windows. sigh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant