This repository has been archived by the owner on Aug 24, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
提出PR #51
Open
ffjlabo
wants to merge
25
commits into
ca-archived:master
Choose a base branch
from
ffjlabo:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
提出PR #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appeal Point / アピールポイント
期限を過ぎたPRとなってしまい申し訳ありません.
期限を過ぎた上に稚拙なコードになっていてPRを送るか迷ったのですが,せっかくの機会なので提出させていただきました.
現状 css などデザイン部分や UX の向上に関しては着手できていません. プレイリスト一覧表示,動画一覧表示,プレイリストの追加,動画の追加に関して必要最低限の実装となっています.
React + Reduxを使ってstoreでapiから取得したデータを一元管理しました.
また,コンポーネントはできるだけPresentational ComponentとContainer Componentに分けるようにしました.アクセストークンはサーバ側で取得し,Cookieにてフロント側へ持たせるようにしています.
Checklist / チェックリスト