Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to LibGit2Sharp 0.30.0 #191

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Update to LibGit2Sharp 0.30.0 #191

merged 1 commit into from
Nov 23, 2024
+2 −2

Conversation

pascalberger
Copy link
Member

@pascalberger pascalberger commented Mar 19, 2024 •
edited
Loading

Update to LibGit2Sharp 0.30.0 and native binaries 2.0.322

augustoproiete
augustoproiete approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joakimia
Copy link

Can this be merged?
Hoping that this solves #165 / #79 for M1 / M2 Macs

@pascalberger
Copy link
Member Author

Hoping that this solves #165 / #79 for M1 / M2 Macs

This won't fix issue when running in Cake Scripting on M1/M2 processor, since this is caused by how the Cake loads the DLLs / how they are packaged in this addin. It already works with the current version of the addin for Cake Frosting.

@pascalberger pascalberger added this to the 5.0.0 milestone Nov 22, 2024
devlead
devlead approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devlead devlead merged commit 2233360 into cake-contrib:develop Nov 23, 2024
6 checks passed
@devlead
Copy link
Member

devlead commented Nov 23, 2024

@pascalberger your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlead devlead devlead approved these changes

@augustoproiete augustoproiete augustoproiete approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pascalberger @joakimia @devlead @augustoproiete