Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Linaria runs code for evaluation in Node environment that does not have DOM APIs, basically following code will throw:
Currently Linaria tries to remove all calls of DOM APIs, the problem is that there a lot of cases where this removal is incomplete or removes valid code. To solve this problem differently this PR injects Happy DOM to
Module
that runs evaluation.This makes DOM APIs available for usage and removes the need to perform code removal.
Test plan
New tests have been added.
Follow ups
packages/utils/src/removeDangerousCode.ts
should be refactored to avoid DOM APIs removal.