Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition in resolve #1334

Merged
merged 25 commits into from
Sep 15, 2023
Merged

Race condition in resolve #1334

merged 25 commits into from
Sep 15, 2023

Conversation

Anber
Copy link
Collaborator

@Anber Anber commented Sep 5, 2023

Motivation

Asynchronous resolver potentially could cause a race condition.

Summary

Adding dependencies to an entrypoint has been moved from asynchronous code to synchronous.

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023

🦋 Changeset detected

Latest commit: 72d419d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@linaria/babel-preset Patch
@linaria/testkit Patch
@linaria/utils Patch
@linaria/cli Patch
@linaria/esbuild Patch
linaria Patch
@linaria/rollup Patch
@linaria/stylelint Patch
@linaria/vite Patch
@linaria/webpack4-loader Patch
@linaria/webpack5-loader Patch
linaria-website Patch
@linaria/atomic Patch
@linaria/core Patch
@linaria/griffel Patch
@linaria/react Patch
@linaria/shaker Patch
@linaria/tags Patch
esbuild-example Patch
rollup-example Patch
vite-example Patch
vpssr-linaria-solid-example Patch
@linaria/webpack-loader Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Anber
Copy link
Collaborator Author

Anber commented Sep 5, 2023

@PierreGUI we found and fixed something here. It might help with your build. Or might not :)

@PierreGUI
Copy link

PierreGUI commented Sep 6, 2023

Thanks, I've tried this build, hélas unsuccessfully. The build of my big entrypoint gets stuck at about 10%, and then runs out of memory.
10% building 0/1 entries 139/143 dependencies 2/68 modules

Note: prepare script fails for @linaria/rollup (but succeeded for babel)

@Anber Anber merged commit aa10045 into master Sep 15, 2023
4 checks passed
@Anber Anber deleted the race-condition-in-resolve branch September 15, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants