Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module): add .cjs extension #1335

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

layershifter
Copy link
Contributor

Motivation

This PR adds .cjs extension to Module in v3. It's required as new version of @swc/helpers uses export maps and points files to .cjs, for example:

"./_/_class_private_field_loose_key": {
  "import": "./esm/_class_private_field_loose_key.js",
  "default": "./cjs/_class_private_field_loose_key.cjs"
},

@layershifter layershifter marked this pull request as ready for review September 8, 2023 10:11
@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2023

⚠️ No Changeset found

Latest commit: 675c0ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Anber Anber merged commit 075b919 into callstack:3.0.x Sep 8, 2023
2 checks passed
@layershifter layershifter deleted the v3/add-cjs branch September 8, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants