-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Resource Deletion concept #2470
Conversation
Adds a warning to indicate users that Zeebe will run a mgiration when updating to 8.3 that may take longer than usual. It mentions how the user could notice this and that it causes some downtime when there is large state.
Adds the DeleteResource RPC to Zeebe's gRPC api docs.
Adds documentation regarding the new resource deletion feature.
@abbasadel FYI, I don't know if you noticed. I requested your review here. I think it's good to have a review from someone less experienced with Zeebe to see if the documentation makes sense 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical review in latest commit, and a few questions for clarity.
1. Process definitions | ||
2. Decision Requirements Graphs (DRG) | ||
|
||
You can delete a resource using [Operate](../../components/operate/operate-introduction.md), or by sending |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would briefly mention how you can delete a resource using Operate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mihail-ca Do you have an issue to document how to use the feature using Operate? If so, could you make sure the link on this page is updated accordingly when this page is created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, this is our Operate epic for this topic: https://github.com/camunda/operate/issues/3972
The relevant issues for documentation are on the front-end side, since the back-end changes are only available via Operate UI. I think this issue explains how to do it: https://github.com/camunda/operate/issues/4019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above is for deleting decision definition - BTW this can be a point of confusion. In Operate one cannot select decision requirements, only a decision definition.
For Process Definition Deletion, the relevant epic and issue on Operate are:
https://github.com/camunda/operate/issues/3971
https://github.com/camunda/operate/issues/4126
Note though that Process Definition Deletion is still work in progress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mihail-ca Will there be a page similar to this one, but for deleting? https://docs.camunda.io/docs/components/operate/userguide/process-instance-modification/
Where can I find the issue for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I am not sure about this. Maybe @pedesen knows, he is DRI for resource deletion on Operate side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@remcowesterhoud @mihail-ca I will create an issue for this in the camunda-platform-docs repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Processed some feedback: - Moved the why before the how - Added more links - Clarified how to delete a process with running instances.
Hi @remcowesterhoud -- let me know if you would like additional review or if you need any help with the build this week 👍 |
@christinaausley I've applied your suggestions, there's one open discussion which I'm trying to get a response to. In the meantime you can give it a 2nd review. Let me request this officially 😄 After @abbasadel also had a look I think I can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Nice work @remcowesterhoud |
7e16dbc
Description
With the 8.3 release we will support resource deletion. This PR adds documentation about this feature.
closes #2264
It also adds a warning to the upgrade guide regarding a larger than usual migration which could impact some users.
closes #2384
When should this change go live?
hold
label or convert to draft PR)?PR Checklist
/versioned_docs
directory, or they are not for an already released version./docs
directory (aka/next/
), or they are not for future versions.