Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs landing page card hyperlinks #4236

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

mesellings
Copy link
Contributor

Description

CSS fix to remove hyperlink padding on docs landing page card components.

Previously, there was padding around card hyperlinks when hovering:

image

  • This is now fixed so the entire card area is hyperlinked.
  • Tested in Google Chrome and Firefox

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@mesellings mesellings added kind/bug Issues related with bugs in the documentation component:docs Documentation improvements, including new or updated content deploy Stand up a temporary docs site with this PR labels Sep 2, 2024
@mesellings mesellings self-assigned this Sep 2, 2024
@mesellings mesellings linked an issue Sep 2, 2024 that may be closed by this pull request
@github-actions github-actions bot temporarily deployed to camunda-docs September 2, 2024 13:36 Destroyed
@mesellings mesellings added the 8.6.0-alpha5 September 2024 alpha release label Sep 3, 2024
@mesellings
Copy link
Contributor Author

@pepopowitz I've tagged you as the reviewer, just to check you are happy with the fix - this can go out whenever you have a chance to review it, it is non-critical but be good to release this week hopefully?

@mesellings mesellings removed the 8.6.0-alpha5 September 2024 alpha release label Sep 3, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs September 3, 2024 16:21 Destroyed
Copy link
Collaborator

@pepopowitz pepopowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 Looks great!

@mesellings mesellings merged commit 4ede447 into main Sep 3, 2024
15 checks passed
@mesellings mesellings deleted the mes-4235-doc-landing-page-card-css branch September 3, 2024 16:53
Copy link
Contributor

github-actions bot commented Sep 3, 2024

🧹 Preview environment for this PR has been torn down.

@akeller
Copy link
Member

akeller commented Sep 3, 2024

@MaxTru this will be fixed with our next docs release. Thanks @mesellings for jumping on this!

@mesellings
Copy link
Contributor Author

@MaxTru This is now live in the latest docs release this morning - thanks for spotting this initially 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content deploy Stand up a temporary docs site with this PR kind/bug Issues related with bugs in the documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Card hyperlink padding on landing page
3 participants