-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(web-modeler): introduce gitlab sync #4583
Conversation
👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉 You can read more about the versioning within our docs in our documentation guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few suggestions here in two separate commits:
If you'd prefer not to introduce tabs at this time, I can roll back the second commit. You should be able to see the change in the deployed preview site, like this:
If any other repository hosts are planned, it will be helpful to have this scaffolding in place to add more options. Alternatively, we could look at creating a generic "Git Sync" page, and add options as their own independent subpages and reusable content. I'd be happy to take on some of this content structuring if it ends up being necessary, and it doesn't need to be decided or implemented here.
Otherwise this looks good to me! I'm approving for now, but can edit/adjust if the structure change isn't warranted at this time.
Yes! That's fantastic! We will indeed add more providers in the (near) future. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side, except one thing about the permissions.
But already approving 👍
29f5aaf
5d8a750
to
0aaa103
Compare
I added a new commit 0aaa103 to:
@conceptualshark, please give me another round of feedback or integrate your proposals directly. CC: @wollefitz, you said we don't need to adjust the docs for the access token change but I changed it nonetheless to be transparent. I marked project access tokens as recommended but did not specify why. Maybe should just mark a personal access token as "not recommended" instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This update looks good to me!
@marcellobarile Feel free to mark this as |
🧹 Preview environment for this PR has been torn down. |
Description
Introduces the GitLab sync functionality, which was added to the existing Git Sync feature.
Epic: https://github.com/camunda/product-hub/issues/2469
Part of https://github.com/camunda/web-modeler/issues/10911
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).