[sshfs_mount] Better logic to determine if mount is active in instance #3286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3286 +/- ##
==========================================
+ Coverage 84.02% 84.04% +0.01%
==========================================
Files 250 250
Lines 13462 13467 +5
==========================================
+ Hits 11312 11318 +6
+ Misses 2150 2149 -1
|
townsend2010
force-pushed
the
fix-unmount-does-not-unmount
branch
from
a5cc9da to
d4b3102
Compare
andrei-toterman
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Hey, @townsend2010! Indeed this seems to fix the issue. Code looks good too.
bors merge
|
Passed CI and integration tests. Will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3164