Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Check whitespace on PRs #3808

Merged
merged 4 commits into from
Dec 10, 2024
Merged

[ci] Check whitespace on PRs #3808

merged 4 commits into from
Dec 10, 2024

Conversation

ricab
Copy link
Collaborator

@ricab ricab commented Dec 3, 2024

No description provided.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (e6e06ab) to head (bae3bc6).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3808   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files         256      256           
  Lines       14583    14584    +1     
=======================================
+ Hits        12971    12972    +1     
  Misses       1612     1612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sploder12
Copy link
Contributor

clang-format provides InsertNewlineAtEOF which could be useful, but it's from version 16 so we'd have to update our versions.

@ricab ricab marked this pull request as ready for review December 3, 2024 21:24
@jibel jibel requested a review from andrei-toterman December 4, 2024 15:48
Copy link
Contributor

@andrei-toterman andrei-toterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this runs only on the Linux workflow. When this runs on the private repo, will it work?

Copy link
Contributor

@andrei-toterman andrei-toterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the public side is all good and I am ready to approve. However, I see that on the private side the lint fails on the packaging/windows/template.rtf file because it does not have a new line at the end of the file. So I will approve this PR, but we need a private PR which fixes that thing as well.

@andrei-toterman andrei-toterman added this pull request to the merge queue Dec 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2024
@ricab ricab added this pull request to the merge queue Dec 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2024
@andrei-toterman andrei-toterman added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 9d4c63e Dec 10, 2024
14 checks passed
@andrei-toterman andrei-toterman deleted the check-whitespace branch December 10, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants