-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Check whitespace on PRs #3808
Conversation
f3baeac
to
4a601cf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3808 +/- ##
=======================================
Coverage 88.94% 88.94%
=======================================
Files 256 256
Lines 14583 14584 +1
=======================================
+ Hits 12971 12972 +1
Misses 1612 1612 ☔ View full report in Codecov by Sentry. |
clang-format provides InsertNewlineAtEOF which could be useful, but it's from version 16 so we'd have to update our versions. |
4a601cf
to
1e2a7ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this runs only on the Linux workflow. When this runs on the private repo, will it work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the public side is all good and I am ready to approve. However, I see that on the private side the lint fails on the packaging/windows/template.rtf
file because it does not have a new line at the end of the file. So I will approve this PR, but we need a private PR which fixes that thing as well.
No description provided.