Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy paste improvements #3849

Open
wants to merge 3 commits into
base: gui-open-shell-start-vm
Choose a base branch
from

Conversation

andrei-toterman
Copy link
Contributor

This PR adds Ctrl+Insert and Shift+Insert as copy/paste shortcuts for the terminal on Windows, as well as adding a right-click context menu in the terminal that provides copy/paste functionality.

It also refactors some of the terminal code by extracting some nested widgets into separate variables, since the nesting level was getting too big.

MULTI-1679

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (859eef1) to head (412a174).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           gui-open-shell-start-vm    #3849   +/-   ##
========================================================
  Coverage                    88.94%   88.94%           
========================================================
  Files                          256      256           
  Lines                        14584    14584           
========================================================
  Hits                         12972    12972           
  Misses                        1612     1612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@levkropp levkropp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested and working on my machine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants