Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added module teardown #295

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

chriskinsman
Copy link

Module teardown to allow closing out connection pools, etc so that nodeunit exit expeditiously after running tests

@chriskinsman
Copy link
Author

Any chance of getting this merged or is there a philosophical reason to not do this?

Happy to go another route and/or eliminate the pull request @mreinstein

Thanks!

@aeisenberg
Copy link
Contributor

I would love to see this PR merged. We have had to do some massive hacks to get similar behavior in our tests.

My guess is that because this project is not active any more, there is no one available who can spend time reviewing this PR.

So, I'll review it myself, even though I am not a committer on this project. Maybe we can push this forward. Some suggestions:

  1. moduleTearDown should run even if there is an error.
  2. It should also be wrapped in a try/catch block
  3. Why are you deleting moduleTearDown from the suite?
  4. A similar moduleSetUp function would be very useful as well, but should probably go in a different PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants