Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request to improve long term project stability. #361

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ stamp-build
gmon.out
v8.log
.DS_Store
package-lock.json
16 changes: 2 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,7 @@ Simple syntax, powerful tools. Nodeunit provides easy async unit testing for
node.js and the browser.


DEPRECATED PROJECT
-----

The project is very stale. We've kept it working on new versions of node, and sometimes merged small PRs that help teams relying on nodeunit.

Nodeunit was the arguably first testing framework developed for node. It was very useful at the time, but there's an overwhelming number
of other worthwhile testing solutions out there that are actively maintained. tap, ava, tape, mocha, jasmine, jest, ... the list goes on and on.

If Nodeunit were truly bringing some different philosophy to the testing scene I'd say yes effort should be made to shore up it's development,
but given how many other great options there are out there, a benefit of letting it atrophy is it's one less choice people have to make when
choosing a testing solution. *You are strongly encouraged to check out other more modern testing options.*

Nodeunit was the arguably first testing framework developed for node.

Features
--------
Expand All @@ -34,6 +23,7 @@ Features
Contributors
------------

* [caolan](https://github.com/caolan)
* [alexgorbatchev](https://github.com/alexgorbatchev)
* [alexkwolfe](https://github.com/alexkwolfe)
* [azatoth](https://github.com/azatoth)
Expand Down Expand Up @@ -367,8 +357,6 @@ Built-in Test Reporters
* __default__ - The standard reporter seen in the nodeunit screenshots
* __minimal__ - Pretty, minimal output, shows errors and progress only
* __html__ - Outputs a HTML report to stdout
* __junit__ - Creates jUnit compatible XML reports, which can be used with
continuous integration tools such as [Hudson](http://hudson-ci.org/).
* __machineout__ - Simple reporter for machine analysis. There is
[nodeunit.vim](https://github.com/lambdalisue/nodeunit.vim) which is useful for TDD on VIM.

Expand Down
13 changes: 1 addition & 12 deletions lib/reporters/index.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,3 @@
// This is a hack to make browserify skip tap
var tap;
try {
tap = require('./' + 'tap');
} catch (ex) {
tap = {
run: function() {
throw new Error('Sorry, tap reporter not available');
}
};
}

module.exports = {
'junit': require('./junit'),
Expand All @@ -18,7 +7,7 @@ module.exports = {
'html': require('./html'),
'eclipse': require('./eclipse'),
'machineout': require('./machineout'),
'tap': tap,
// 'tap': require('./tap'),
'nested': require('./nested'),
'verbose' : require('./verbose'),
'lcov' : require('./lcov')
Expand Down
3 changes: 2 additions & 1 deletion lib/reporters/junit.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ var nodeunit = require('../nodeunit'),
async = require('../../deps/async'),
AssertionError = require('../assert').AssertionError,
child_process = require('child_process'),
ejs = require('ejs');
// ejs = require('ejs');
ejs = require('template-literal');


/**
Expand Down
21 changes: 14 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
{
"name": "nodeunit",
"version": "0.11.3",
"version": "1.0.0",
"description": "Easy unit testing for node.js and the browser.",
"maintainers": [
{
"name": "Caolan McMahon",
"web": "https://github.com/caolan"
"name": "Chris Johnson",
"web": "https://github.com/chrisjohn404"
}
],
"contributors": [
{
"name": "Caolan McMahon",
"web": "https://github.com/caolan"
},
{
"name": "Romain Beauxis",
"web": "https://github.com/toots"
Expand Down Expand Up @@ -60,14 +64,14 @@
],
"repository": {
"type": "git",
"url": "http://github.com/caolan/nodeunit.git"
"url": "http://github.com/chrisjohn404/nodeunit.git"
},
"devDependencies": {
"should": ">=11.1.0",
"uglify-js": ">=2.7.3"
},
"bugs": {
"url": "http://github.com/caolan/nodeunit/issues"
"url": "http://github.com/chrisjohn404/nodeunit/issues"
},
"license": "MIT",
"directories": {
Expand All @@ -78,11 +82,14 @@
"bin": {
"nodeunit": "./bin/nodeunit"
},
"dependencies": {
"depDependencies": {
"ejs": "^2.5.2",
"tap": "^12.0.1"
"tap": "^16.0.1"
},
"scripts": {
"test": "node ./bin/nodeunit"
},
"dependencies": {
"template-literal": "^1.0.4"
}
}