[ADP-3487] Make deposit WalletState more strict
#4862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
changed the title
WalletState more strictWalletState more strict
paolino
approved these changes
Nov 28, 2024
lib/customer-deposit-wallet/src/Cardano/Wallet/Deposit/Pure/State/Type.hs
Show resolved
Hide resolved
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
- Make deposit wallet state more strict with StrictData
- Bump cardano-wallet-agda for new increased strictness from
- cardano-foundation/cardano-wallet-agda#116
- cardano-foundation/cardano-wallet-agda#117
Depends on #4856 (or tested with it at least, but probably mergeable
without it as well)
## Results
### This PR
~600-800 MB memory usage when syncing with preprod
The heap profile suggests we still have a memory leak, but this is not
immediately observable in the os's activity monitor, so this is a lot
better than before.
### Previously
([anviking/ADP-3487/NodeToClient](https://github.com/cardano-foundation/cardano-wallet/tree/anviking/ADP-3487/NodeToClient)
)
9 GB and growing acording to os's activity monitor:
### Issue Number
ADP-3494
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This is an unprincipled fix for the following macOS specific unit test failure: https://buildkite.com/cardano-foundation/cardano-wallet/builds/8283#019377d9-7963-4ff1-8c42-f270f8669a0c
Anviking
force-pushed
the
anviking/ADP-3494/StrictData
branch
from
2439275 to
dc3cb52
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StrictDatato long-lived data structures cardano-wallet-agda#116UTxOHistory.Typemodule cardano-wallet-agda#117Depends on #4856 (or tested with it at least, but probably mergeable without it as well)
Results
This PR
~600-800 MB memory usage when syncing with preprod
The heap profile suggests we still have a memory leak, but this is not immediately observable in the os's activity monitor, so this is a lot better than before.
Previously (anviking/ADP-3487/NodeToClient )
9 GB and growing acording to os's activity monitor:
Issue Number
ADP-3494