Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3479] Fix private key creation #4863

Merged
merged 13 commits into from
Dec 6, 2024
Merged

[ADP-3479] Fix private key creation #4863

merged 13 commits into from
Dec 6, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Nov 29, 2024 •
edited
Loading

  • Expose wallet state functions from the REST interface, useful in the the next PR and somehow happened here
  • Use mnemonic management from cardano-addresses
  • Add a golden test that we can create the same credentials ads cardano-addresses cli tool

@paolino paolino changed the title Paolino/ADP-3479/fix-private-key-creation [ADP-3479] Fix private key creation Nov 29, 2024
@paolino paolino changed the base branch from master to anviking/ADP-3494/StrictData November 29, 2024 13:50
@paolino paolino force-pushed the paolino/ADP-3479/fix-private-key-creation branch from 50b433a to ec08df2 Compare November 29, 2024 14:58
@paolino paolino self-assigned this Nov 29, 2024
@paolino paolino force-pushed the paolino/ADP-3479/fix-private-key-creation branch 5 times, most recently from fa8707d to 19aa866 Compare November 29, 2024 16:06
Base automatically changed from anviking/ADP-3494/StrictData to master November 29, 2024 16:21
@abailly abailly mentioned this pull request Nov 29, 2024
Merged
abailly
abailly reviewed Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@abailly abailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR based off the right branch? It seems to me there are much more changes than the fixing of private key creation

lib/customer-deposit-wallet/http/Cardano/Wallet/Deposit/HTTP/Server.hs Outdated Show resolved Hide resolved
lib/customer-deposit-wallet/src/Cardano/Wallet/Deposit/Pure/State/Creation.hs Outdated Show resolved Hide resolved
lib/customer-deposit-wallet/src/Cardano/Wallet/Deposit/Pure/State/Payment.hs Outdated Show resolved Hide resolved
lib/customer-deposit-wallet/src/Cardano/Wallet/Deposit/Pure/State/Payment/Inspect.hs Outdated Show resolved Hide resolved
@paolino paolino force-pushed the paolino/ADP-3479/fix-private-key-creation branch 2 times, most recently from 4ef48d6 to 0200b5a Compare December 5, 2024 14:22
@paolino paolino requested a review from abailly December 5, 2024 14:23
@paolino
Copy link
Collaborator Author

paolino commented Dec 5, 2024

@abailly I can extract the unrelated exposures if you find them unacceptable in this PR

abailly
abailly approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@abailly abailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to split this PR, but in general smaller, focused PRs are easier to review. Not that I am a big fan of code reviews, I'd rather pair more, but 🤷

lib/customer-deposit-wallet/src/Cardano/Wallet/Deposit/Pure/State/Creation.hs Outdated Show resolved Hide resolved
lib/customer-deposit-wallet/test/unit/Cardano/Wallet/Deposit/Write/KeysSpec.hs Show resolved Hide resolved
@paolino paolino force-pushed the paolino/ADP-3479/fix-private-key-creation branch from 0200b5a to 2876118 Compare December 6, 2024 08:53
@paolino paolino enabled auto-merge December 6, 2024 08:53
@paolino paolino force-pushed the paolino/ADP-3479/fix-private-key-creation branch from 2876118 to 925cd15 Compare December 6, 2024 08:54
@paolino paolino added this pull request to the merge queue Dec 6, 2024
Merged via the queue into master with commit 3679fbd Dec 6, 2024
24 checks passed
@paolino paolino deleted the paolino/ADP-3479/fix-private-key-creation branch December 6, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abailly abailly abailly approved these changes

@Anviking Anviking Awaiting requested review from Anviking

@paweljakubas paweljakubas Awaiting requested review from paweljakubas

Assignees

@paolino paolino

Labels
Bug Deposit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @abailly