This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Fixed some warnings + added new warnings for unit tests #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not really a major change, but it helps out for any project that tries to build without any warnings like I do.
Added
-Wshadow
and-Wsign-conversion
warnings to the gcc + clang warnings for the test suite. GCC does not turn these on by default with-Wall
or-Wextra
, and I don't know if clang bundles them the added warnings in its-Wall
or-Wextra
.Also fixed a few lines in the headers that raised these warnings, namely appending an underscore for the shadow warning and a static cast to the sign conversion warning. I went with the underscore on the arguments as I figured there was a good reason that the
TokenStream::it
andTokenStream::itEnd
members didn't have anm_
prefix.