Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heading link styles #1156

Closed
wants to merge 1 commit into from
Closed

Add heading link styles #1156

wants to merge 1 commit into from

Conversation

alexm118
Copy link

Issue #1069 asks for documentation around links that are also heading elements. Our current system does not have a method for styling links with black text so I am adding a new class to apply to links.

Additions

  • a-link__heading which colors the link black like an h4 would be, as well as alters the default hover appearance to mirror what is currently done on cfgov.

Testing

  1. Ran the a11y tests.

Screenshots

Notes

  • Not sure if this is the correct process for adding these links

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the CFPB development guidelines
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Browsers

  • Chrome on desktop
  • Firefox
  • Safari on macOS
  • Edge
  • Internet Explorer 9, 10, and 11
  • Safari on iOS
  • Chrome on Android

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@netlify
Copy link

netlify bot commented Jan 12, 2021

✔️ Thanks for the improvements! Browse a preview of your changes using the link below.

🔨 Explore the source changes: c680122

🔍 Inspect the deploy logs: https://app.netlify.com/sites/cfpb-design-system/deploys/5ffdf229b6c28100086a73d3

😎 Browse the preview: https://deploy-preview-1156--cfpb-design-system.netlify.app

@chosak
Copy link
Member

chosak commented Jan 14, 2021

Thanks @alexm118! Could you possibly also add a documentation edit to the links page to demonstrate how this proposed style would look?

@anselmbradford
Copy link
Member

Is this currently used in the cf.gov codebase somewhere?

@Scotchester
Copy link
Contributor

I think this PR misconstrues what the original issue (#1069) wants. As I understand it, the desired change is to add written content to the DS's Links page describing how links within headings are styled.

@Scotchester
Copy link
Contributor

Headings that linked, that is. Where the entire text of the heading is a link.

@sonnakim sonnakim closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants