Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add definitions custom class to notify event (fixes #10) #11

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Fix: Add definitions custom class to notify event (fixes #10) #11

merged 1 commit into from
Nov 26, 2024

Conversation

guywillis
Copy link
Contributor

Fixes: #10

Fix

  • Adds definitions custom class to notify event to allow for differentiation between other pop ups in the course.

@guywillis guywillis self-assigned this Nov 26, 2024
kirsty-hames
kirsty-hames approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks 👍

@guywillis guywillis merged commit a3ce8e9 into master Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@guywillis guywillis

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add notify definitions custom class
2 participants
@guywillis @kirsty-hames