Fix identity refresh bug for all roles #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduenas
reviewed
Aug 8, 2024
| notes: > | ||
| Fix issue where some fields were not refreshed | ||
| in the identities database under certain | ||
| circumstances. |
There was a problem hiding this comment.
I would be good to explain here that circustances.
There was a problem hiding this comment.
I updated the changelog, let me know if that is enough or if I should include more information.
This commit resolves an issue where role identities (like `reviewed_by` or `merged_by` among others) were not refreshed. The bug occurred because the queries to OpenSearch filtered items in which `author_uuid` was the individual pk, but not when the `<role>_uuid` was the individual pk. That causes many items that contain the `<role>_uuid` but not the `author_uuid` not to be refreshed. For example, the `Author` role was not affected because it matched `author_uuid`, but roles like `reviewed_by` did not match and were missed. Signed-off-by: Jose Javier Merchante <[email protected]>
jjmerchante
force-pushed
the
fix-roles-refresh
branch
from
1ecdd73
to
12b99cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where role identities (like
reviewed_byormerged_byamong others) were not refreshed.The bug occurred because the queries to OpenSearch filtered items in which
author_uuidwas the individual pk, but not when the<role>_uuidwas the individual pk. That causes many items that contain the<role>_uuidbut not theauthor_uuidnot to be refreshed.For example, the
Authorrole was not affected because it matchedauthor_uuid, but roles likereviewed_bydid not match and were missed.This PR depends on chaoss/grimoirelab-elk#1163
This PR fixes chaoss/grimoirelab-elk#1161