Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #3398 chef-server-ctl test in failing in FIPS enabled Amazon Linux 2 system #3399

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

srijitncoupa
Copy link

Description

Please find changes done for fixing of FIPS issue for following issue. #3398. Code changes is done for following file oc_erchef.config.erb

{chef_objects, [
<% if node['private_chef']['fips_enabled'] -%>
%% When we're using a fips openssl, we default to using http for bookshelf.
%% The reason for this is because we do not have a TLS implementation for
%% Erlang when we turn on fips.
%%
%% This is the reason that the only supported configuration for the fips
%% package is standalone. We will allow http over localhost so that the
%% chef server can talk to bookshelf. We can give provide bookshelf['url'] = 'http://127.0.0.1:4321' for making it work for FIPS enabled
%% {s3_url, "http://<%= node['private_chef']['bookshelf']['listen'] %>:<%= node['private_chef']['bookshelf']['port'] %>"},
{s3_url, "<%= @helper.bookshelf_s3_url %>"},
<% else -%>
{s3_url, "<%= @helper.bookshelf_s3_url %>"},
<% end %>

Issues Resolved

#3398 : chef-server-ctl test in failing in FIPS enabled Amazon Linux 2 system

Check List

srijitncoupa and others added 2 commits July 7, 2022 16:08
chef#3398: Fix for FIPS enabled in bookshelf using bookshelf s3 url with …
@srijitncoupa srijitncoupa requested review from a team as code owners July 8, 2022 18:10
@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@netlify
Copy link

netlify bot commented Jul 8, 2022

👷 Deploy Preview for chef-server processing.

Name Link
🔨 Latest commit 058367e
🔍 Latest deploy log https://app.netlify.com/sites/chef-server/deploys/62c87300c9748c000882d652

{s3_url, "http://<%= node['private_chef']['bookshelf']['listen'] %>:<%= node['private_chef']['bookshelf']['port'] %>"},
%% chef server can talk to bookshelf. We can give provide bookshelf['url'] = 'http://127.0.0.1:4321' for naking it work for FIPS enabled
%% {s3_url, "http://<%= node['private_chef']['bookshelf']['listen'] %>:<%= node['private_chef']['bookshelf']['port'] %>"},
{s3_url, "<%= @helper.bookshelf_s3_url %>"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a TLS implementation for Erlang when we turn on FIPS? Tracing this back - it looks like the helper still calls https(x_forwarded_proto defaults to https)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also if this were the right path, I would remove the if clause instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that part is not there . Is the TLS implementation of Erlang has relation with following issue #2088.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently the workaround allows to communicate with external s3 even in FIPS enabled chef server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants