-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chef 11677/chef 12498/lbaker erlang upgrade #3877
Open
lbakerchef
wants to merge
5
commits into
main
Choose a base branch
from
CHEF-11677/CHEF-12498/lbaker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-server processing.
|
lbakerchef
force-pushed
the
CHEF-11677/CHEF-12498/lbaker
branch
4 times, most recently
from
August 22, 2024 16:24
d887553
to
6f7fb13
Compare
Quality Gate failedFailed conditions |
sreepuramsudheer
force-pushed
the
CHEF-11677/CHEF-12498/lbaker
branch
from
September 11, 2024 14:07
6f7fb13
to
ce45087
Compare
lbakerchef
force-pushed
the
CHEF-11677/CHEF-12498/lbaker
branch
from
October 7, 2024 18:20
ce45087
to
1dfe2ad
Compare
lbakerchef
force-pushed
the
CHEF-11677/CHEF-12498/lbaker
branch
from
November 7, 2024 18:44
ab05d25
to
f7ed692
Compare
lbakerchef
force-pushed
the
CHEF-11677/CHEF-12498/lbaker
branch
11 times, most recently
from
November 26, 2024 14:27
44f03f6
to
4802a1c
Compare
Update to Erlang 26.2.5.2 Update plan.sh files to erlang26 Upgrade rebar3 Recompile Elvis and fix elvis complaints Remove eper It's old and unmaintained, and now it won't compile without warnings. the last commit was 6-10 years ago. Most of the tools within it now have more updated equivalents elsewhere. Choices: 1) just remove it 2) fork it, fix compile errors, maintain it 3) remove it, then when and where needed, use updated equivalents. For now, going with #1. Fix compilation errors in depsolver Fix undefined type error and syntax error. Fix dialyzer errors pg2 -> pg pg2 was removed by Erlang. start -> ensure_started Add {minor_version, 1} option to term_to_binary pursuant to Erlang 26 update. term_to_binary changed. This option is now needed in order to maintain current behavior and avoid failures. Add [{minor_version, 1}] option to all term_to_binary function calls It's probably not good to have some calls using this option and other calls not using it. Fix /_stats API pedant test failure following update to erlang 26x 2) /_stats API endpoint returns prometheus output ?format=text Failure/Error: expect(names.uniq).to match_array(PROMETHEUS_RESPONSE_TYPE_MAP.keys) expected collection contained: ["chef_index_batch_completed_latency_ms_bucket", "chef_index_batch_completed_latency_ms_count", "chef... "pg_stat_tidx_blks_read", "pg_stat_toast_blks_hit", "pg_stat_toast_blks_read", "pg_stat_tup_fetch"] actual collection contained: ["chef_index_batch_completed_latency_ms_bucket", "chef_index_batch_completed_latency_ms_count", "chef... "pg_stat_tidx_blks_read", "pg_stat_toast_blks_hit", "pg_stat_toast_blks_read", "pg_stat_tup_fetch"] the missing elements were: ["erlang_mnesia_committed_transactions", "erlang_mnesia_failed_transactions", "erlang_mnesia_held_loc...d_transactions", "erlang_mnesia_transaction_coordinators", "erlang_mnesia_transaction_participants"] # ./spec/api/stats_spec.rb:218:in `block (2 levels) in <top (required)>' Add ssl option verify_none following update to Erlang 26. Erlang changed this from a default option to an option which now has to be specified. Not specifying it was causing failures in SSL when using a self-signed cert (see below). 1) Server-side reindexing reindexing OPC it should behave like Reindexing works for all object types Failure/Error: identifiers.should_not include(name) expected ["pedant_node_test"] not to include "pedant_node_test" Shared Example Group: "Reindexing" called from ./spec/api/reindex_spec.rb:20 # ./lib/pedant/rspec/search_util.rb:932:in `block in do_search' # ./lib/pedant/rspec/search_util.rb:769:in `with_search_polling' # ./lib/pedant/rspec/search_util.rb:919:in `do_search' # ./lib/pedant/rspec/search_util.rb:888:in `should_not_find' # ./lib/pedant/rspec/search_util.rb:950:in `block (2 levels) in <module:RSpec>' Signed-off-by: Lincoln Baker <[email protected]>
lbakerchef
force-pushed
the
CHEF-11677/CHEF-12498/lbaker
branch
3 times, most recently
from
November 27, 2024 06:59
34c1625
to
aaefd39
Compare
testing with LTS-2024 adding studio secretes Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
lbakerchef
force-pushed
the
CHEF-11677/CHEF-12498/lbaker
branch
from
November 27, 2024 07:48
aaefd39
to
936b224
Compare
Signed-off-by: Lincoln Baker <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>
Quality Gate failedFailed conditions |
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.