Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chef 11677/chef 12498/lbaker erlang upgrade #3877

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lbakerchef
Copy link
Contributor

No description provided.

@lbakerchef lbakerchef self-assigned this Aug 15, 2024
@lbakerchef lbakerchef requested review from a team as code owners August 15, 2024 02:17
Copy link

netlify bot commented Aug 15, 2024

👷 Deploy Preview for chef-server processing.

Name Link
🔨 Latest commit d51e584
🔍 Latest deploy log https://app.netlify.com/sites/chef-server/deploys/6747a36dc8860c000846816e

@lbakerchef lbakerchef force-pushed the CHEF-11677/CHEF-12498/lbaker branch 4 times, most recently from d887553 to 6f7fb13 Compare August 22, 2024 16:24

Quality Gate failed Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@lbakerchef lbakerchef force-pushed the CHEF-11677/CHEF-12498/lbaker branch 11 times, most recently from 44f03f6 to 4802a1c Compare November 26, 2024 14:27
Update to Erlang 26.2.5.2

Update plan.sh files to erlang26

Upgrade rebar3

Recompile Elvis and fix elvis complaints

Remove eper

    It's old and unmaintained, and now it won't compile without warnings.
    the last commit was 6-10 years ago.

    Most of the tools within it now have more updated equivalents
    elsewhere.

    Choices:

    1) just remove it
    2) fork it, fix compile errors, maintain it
    3) remove it, then when and where needed, use updated equivalents.

    For now, going with #1.

Fix compilation errors in depsolver

Fix undefined type error and syntax error.

Fix dialyzer errors

pg2 -> pg
    pg2 was removed by Erlang.

start -> ensure_started

Add {minor_version, 1} option to term_to_binary pursuant to Erlang 26 update.

    term_to_binary changed.  This option is now needed in order to maintain
    current behavior and avoid failures.

Add [{minor_version, 1}] option to all term_to_binary function calls

    It's probably not good to have some calls using this option and other
    calls not using it.

Fix /_stats API pedant test failure following update to erlang 26x

  2) /_stats API endpoint returns prometheus output ?format=text
     Failure/Error: expect(names.uniq).to match_array(PROMETHEUS_RESPONSE_TYPE_MAP.keys)

       expected collection contained:  ["chef_index_batch_completed_latency_ms_bucket", "chef_index_batch_completed_latency_ms_count", "chef... "pg_stat_tidx_blks_read", "pg_stat_toast_blks_hit", "pg_stat_toast_blks_read", "pg_stat_tup_fetch"]
       actual collection contained:    ["chef_index_batch_completed_latency_ms_bucket", "chef_index_batch_completed_latency_ms_count", "chef... "pg_stat_tidx_blks_read", "pg_stat_toast_blks_hit", "pg_stat_toast_blks_read", "pg_stat_tup_fetch"]
       the missing elements were:      ["erlang_mnesia_committed_transactions", "erlang_mnesia_failed_transactions", "erlang_mnesia_held_loc...d_transactions", "erlang_mnesia_transaction_coordinators", "erlang_mnesia_transaction_participants"]
     # ./spec/api/stats_spec.rb:218:in `block (2 levels) in <top (required)>'

Add ssl option verify_none following update to Erlang 26.

    Erlang changed this from a default option to an option which now has to
    be specified.  Not specifying it was causing failures in SSL when using
    a self-signed cert (see below).

    1) Server-side reindexing reindexing OPC it should behave like Reindexing works for all object types
       Failure/Error: identifiers.should_not include(name)
         expected ["pedant_node_test"] not to include "pedant_node_test"
       Shared Example Group: "Reindexing" called from ./spec/api/reindex_spec.rb:20
       # ./lib/pedant/rspec/search_util.rb:932:in `block in do_search'
       # ./lib/pedant/rspec/search_util.rb:769:in `with_search_polling'
       # ./lib/pedant/rspec/search_util.rb:919:in `do_search'
       # ./lib/pedant/rspec/search_util.rb:888:in `should_not_find'
       # ./lib/pedant/rspec/search_util.rb:950:in `block (2 levels) in <module:RSpec>'

Signed-off-by: Lincoln Baker <[email protected]>
@lbakerchef lbakerchef force-pushed the CHEF-11677/CHEF-12498/lbaker branch 3 times, most recently from 34c1625 to aaefd39 Compare November 27, 2024 06:59
testing with LTS-2024

adding studio secretes

Signed-off-by: RoyShravani <[email protected]>
Signed-off-by: Lincoln Baker <[email protected]>

Quality Gate failed Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Copy link

sonarcloud bot commented Nov 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants