Reduce size of HID class request buffer #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the change from cherry-embedded#260, this buffer no longer needs to be so large. It can be reduced to the save a lot of memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change from #260, this buffer no longer needs to be so large. It can be reduced to the save a lot of memory.
The only reason this buffer was 256 bytes was to accommodate the descriptor request. With that now changed, 64 bytes should be more than enough.
Since CherryUSB statically allocates a lot of data structures, this should save quite a bit of memory when a host is configured to support multiple HID devices.