[#680] Add support to get groups for users from secondary domain #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #681 +/- ##
==========================================
- Coverage 76.61% 76.59% -0.02%
==========================================
Files 58 58
Lines 8059 8061 +2
Branches 667 667
==========================================
Hits 6174 6174
- Misses 1734 1736 +2
Partials 151 151
|
|
@dumol not urgent. When you have time, can you check why the docker tests are failing looks like this fails due to our github checkout process |
Known issue, documented at https://github.com/chevah/compat/blob/master/.github/workflows/docker.yml#L105. |
|
This was deployed to customer, but the issue was not fixed. This is complicated, as this is a multi-domain Windows VM, with one-way trust for one of the domain.... complicated stuff and I have no idea how to setup such a Windows domain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Authentication doesn't fully work for users from a secondary domain.
The credentials are validated, but then getting the groups fails.
Changes
Run the group opration in impersonation mode as the newly authenticated user.
Drive-by changes:
python-packagerepo, bringing support for more Alpine versions and RHEL 9.How to try and test the changes
reviewers: @danuker
FYI