Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For "needs-review" marker ask for a review via the "Reviewers" PR metadata. #44

Open
adiroiban opened this issue Jul 10, 2022 · 2 comments
Assignees
Labels

Comments

@adiroiban
Copy link
Member

Right now, when a review is requested the targeted reviewers are "assigned" to that PR.

This is due to legacy reasons, as in the past there was no "reviewers" metadata for the PR.

Now, instead of assigning a PR to the reviewers, the reviewers should be assigned via the dedicated field.

In summary:

  • The "Assignees" field should contain the list of PR drivers. Persons who will make changes to get the PR approved.
  • The "Reviewers" filed should contain the list of PR reviewers. Persons who should check the changes and approve or reject them.

Here are the 2 fields.

image


Note that this is only valid for PRs.

For issues, we will continue to have the existing behavior via "Assignees"

@danuker
Copy link
Contributor

danuker commented Aug 18, 2022

testing.

needs-review

@adiroiban
Copy link
Member Author

For an issue, we will still use the "Asigneed" field, as there is no "reviewers" metadata for an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants