Forward-ported fixes from python-package. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiroiban
reviewed
Apr 25, 2022
This reverts commit ceb021b.
Co-authored-by: Adi Roiban <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Bring latest improvements from our
python-packagerepo for building Python 2.7 packages.Changes
Forward-ported updates from python-package:
Drive-by changes:
brink.{conf,sh}aspythia.{conf.sh}. Fixes Rename pythia.sh script. #31.pip, and most Python modules to the newest versions.cryptographyupdated to the latest version not requiring Rust. (Newer versions would practically mean we use binary wheels only forcryptography, so at least CentOS 6 would be required.)I've tried updating Python to latest 3.8 versions. There are 2 main issues:
readlinepatch needs to be updated even for 3.8.10. Thus, I would rather put in the required work when upgrading to a new major version like 3.10.Testing
Please review changes. Sorry for cramming too much stuff into this PR! Maybe review the commits individually? I've tried to keep things tidy.
Automatic tests should be all green.