Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-451) Fix Boxstarter Package Parameter '-StopOnPackageFailure' #452

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

mwallner
Copy link
Member

Description

In the code that evaluates Boxstarter Package Parameters, 'StopOnPackagaFailure' is only recognized (and therefore stripped from the 'chocolatey parameter string) if, and only if 'RebootCodes' were present in the original parameter string.

Related Issue

Fixes #451

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mwallner mwallner requested a review from pauby October 19, 2020 18:15
tests/Chocolatey/Chocolatey.tests.ps1 Show resolved Hide resolved
Boxstarter.Chocolatey/Chocolatey.ps1 Show resolved Hide resolved
Boxstarter.Chocolatey/Chocolatey.ps1 Show resolved Hide resolved
Boxstarter.Chocolatey/Chocolatey.ps1 Show resolved Hide resolved
@pauby
Copy link
Member

pauby commented Oct 20, 2020

Can you update your commit messages to reference the issue number - ie. (GH-451) <COMMIT MESSAGE>?

@pauby pauby changed the title Fix Boxstarter Package Parameter '-StopOnPackageFailure' (GH-451) Fix Boxstarter Package Parameter '-StopOnPackageFailure' Oct 20, 2020
@pauby pauby merged commit 26fd98a into chocolatey:master Jan 19, 2021
@pauby
Copy link
Member

pauby commented Jan 19, 2021

@mwallner Awesome work! Thanks for your contribution!

@mwallner mwallner deleted the GH-451 branch April 27, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter '-StopOnPackageFailure' should work without requiring parameter '-RebootCodes'
2 participants