This repository has been archived by the owner on Nov 17, 2018. It is now read-only.
RSpec fixes and the like #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Withdrawn, as I've switched to gravatar-ultimate |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Chris,
I rebased my fork of gravtastic to get your latest changes. While doing that, I ran into some problems (e.g. the specs weren't passing).
I know you don't agree with my approach of having a public Gravtastic.gravtastic_url, but I hope you will at least consider cherry-picking my other commits. The first commit updates the specs to account for the new http default, and the second and third commits have some changes that I needed to be able to run tests. They allow tests to run on a fresh checkout, after doing the standard
bundle install, with abundle exec rake spec.Thank you,
Victor