Fix compile error on linux 6.6 #85
Conversation
|
Please merge this. I can't build exanic on ubuntu 22.04 without it. |
|
By the way, I have kernel 6.5.0-26-generic #26~22.04.1-Ubuntu and I still face the same compilation errors, so probably the version checks in this patch should be downgraded to kernel 6.5 (or earlier). |
Co-authored-by: PJ Waskiewicz <[email protected]>
|
oh, I'm afraid it's not enough. It doesn't compile if I don't change all the checks to kernel 6.5 or earlier. |
|
@pdavydov108 I only tested LTS stable kernel version only (6.1 switch to 6.6), for stable and mainline kernel version, I have little of time to test. I am not familiar change logs of kernel. I just search kernel commits in https://github.com/torvalds/linux to found and lucky got the answer. It is welcome for you to modify the version condition and test it on kernel 6.5. |
|
I can fix and test across the different versions and get all the various bits sorted out. It’ll just take me a bit since I’m traveling at the moment. |
| exabond_masters_show(struct class *c, | ||
| #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 34) | ||
| exabond_masters_show( | ||
| #if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 6, 0) |
There was a problem hiding this comment.
This has changed on 6.4.0 from what I can see, not 6.6.0
|
The version check should be for 6.4.0 not 6.6.0 in some places. If you want to see when the interface changed, it's useful to use a website like below https://elixir.bootlin.com/linux/v6.4/source/include/linux/device/class.h |
Linux 6.6 has several minor changes which result in compile errors and compile warnings.