Add support for 6 in params.pp #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Puppet 3 is out of life since too much time. I think we need to remove the support of this branch. I don't now if you again require this merge request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to shoehorn varnish6-support into the puppet3-branch.
Cherry-picking 170214c and e98b9fc, plus changed 5 into 6 in the regexp covering allowable versions.
(We do use centos7 with puppet3. The README states that varnish6 is not supported on centos7, though I'd like to give it a shot. I'll choose Ubuntu 18.04 and Puppet5 if I have to)