Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New hostname feature breaks user-data #59

Closed
Timbus opened this issue Jan 16, 2023 · 1 comment · Fixed by #60
Closed

New hostname feature breaks user-data #59

Timbus opened this issue Jan 16, 2023 · 1 comment · Fixed by #60

Comments

@Timbus
Copy link

Timbus commented Jan 16, 2023

The change made in commit bd96e69 writes the hostname to the constructed cloud-init config. That's cool but unfortunately it doesn't appear to write a newline after the host value.
This means due to the strange composition behavior documented in issue #54, userdata is now being appended to the hostname and is not running correctly.

My workaround has been to tweak our userdata to contain newlines at the start. It feels a bit hacky
bwarden added a commit to bwarden/micro-config-drive that referenced this issue Jan 26, 2023
@bwarden
Add a newline after hostname entry
6872cc3 
Always add a newline after printing the hostname: entry, just in case
userdata API call returns *just* the hostname.
Update the test data to just such a bare hostname.

Fixes clearlinux#59
@bwarden bwarden mentioned this issue Jan 26, 2023
Merged
bwarden added a commit to bwarden/micro-config-drive that referenced this issue Jan 26, 2023
@bwarden
Add a newline after hostname entry
73cf865 
Always add a newline after printing the hostname: entry, just in case
userdata API call returns *just* the hostname.
Update the test data to just such a bare hostname.

Fixes clearlinux#59
@bwarden
Copy link
Member

bwarden commented Jan 27, 2023

Watch for https://github.com/clearlinux-pkgs/micro-config-drive/releases/tag/48-35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a newline after hostname entry bwarden/micro-config-drive
2 participants
@Timbus @bwarden