Add a newline after hostname entry #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always add a newline after printing the hostname: entry, just in case userdata API call returns *just* the hostname. Update the test data to just such a bare hostname. Fixes clearlinux#59
bwarden
force-pushed
the
fix-hostname-no-newline
branch
from
6872cc3 to
73cf865
Compare
fenrus75
approved these changes
Jan 26, 2023
bryteise
reviewed
Jan 26, 2023
| @@ -1 +1 @@ | |||
| myhostname | |||
| myhostname | |||
There was a problem hiding this comment.
Any reason to not have both the newline including file and not (I might not be understanding how tests work).
There was a problem hiding this comment.
The test spawns a web server that serves the literal contents of the files under tests/fetch_data. It would be good to restructure the test to support multiple scenarios like that, but not presently supported.
|
Prettier solution would be to make |
bwarden
force-pushed
the
fix-hostname-no-newline
branch
from
a26fcd0 to
4969696
Compare
|
Reworked to make |
bryteise
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always add a newline after printing the
hostname:entry, just in case userdata API call returns just the hostname.Update the test data to just such a bare hostname.
Fixes #59