Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup GitHub codeowners file and required reviewers repo rule #38

Closed
2 tasks done
andyfeller opened this issue Sep 15, 2023 · 1 comment · Fixed by #39
Closed
2 tasks done

Setup GitHub codeowners file and required reviewers repo rule #38

andyfeller opened this issue Sep 15, 2023 · 1 comment · Fixed by #39
Assignees
@andyfeller

Comments

@andyfeller
Copy link
Contributor

andyfeller commented Sep 15, 2023 •
edited
Loading

Overview

Initially called out in #37 by @manue1, this issue is to ensure we have our standard CODEOWNERS file in place so core maintainers are automatically assigned to pull requests.

Action Items

  • Create codeowners file for CLI core maintainers over all changes
  • Ensure repository has appropriate repository ruleset configured to require reviews from codeowners
@andyfeller andyfeller self-assigned this Sep 15, 2023
@andyfeller andyfeller mentioned this issue Sep 15, 2023
Merged
@andyfeller
Copy link
Contributor Author

Along with opening the PR, I've also updated the existing branch protection rule to require review from codeowners. This should trigger the auto assign of reviewers going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyfeller andyfeller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding essential codeowners file cli/gh-extension-precompile
1 participant
@andyfeller