Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding essential codeowners file #39

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

andyfeller
Copy link
Contributor

@andyfeller andyfeller commented Sep 15, 2023

Closes #38

This is a simple version of the cli/cli codeowners file. Separately, I will review the repository settings to see about the missing repository ruleset for leveraging this.

@andyfeller andyfeller self-assigned this Sep 15, 2023
@andyfeller andyfeller merged commit 73d4e83 into trunk Sep 18, 2023
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like GitHub is complaining that @cli/code-reviewers does not exist... not sure what that is about. I am going to approve this anyway.

@samcoe samcoe deleted the andyfeller/38-codeowners branch September 18, 2023 08:33
@andyfeller
Copy link
Contributor Author

Thanks for catching that, @samcoe 🤦

The problem is not that the team didn't exist but that the team didn't have explicit permission to the repository. In copying and slimming down the version from cli/cli in the terminal, it doesn't make errors like this visible so I missed it.

Problem should be fixed now 👍
Screenshot 2023-09-18 at 7 48 52 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup GitHub codeowners file and required reviewers repo rule
2 participants