Fix building with go 1.16 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newly added platform `windows-arm64` isn't available on Go 1.16. In fact, any unsupported "GOOS-GOARCH" pair should be skipped so that we can keep adding platforms in the future without worrying about whether the Go version that an extension author has chosen for their project supports that platform.
samcoe
approved these changes
Jun 8, 2022
|
@samcoe No, I think that might be a breaking change, so maybe best kept for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly added platform
windows-arm64isn't available on Go 1.16. In fact, any unsupported "GOOS-GOARCH" pair should be skipped so that we can keep adding platforms in the future without worrying about whether the Go version that an extension author has chosen for their project supports that platform.Thanks @samcoe for spotting this bug