bug: Prevent draft release creation if release already exists #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is exactly the case! |
daido1976
added a commit
to daido1976/gh-report
that referenced
this pull request
Dec 28, 2022
Fix problem of 27fd475 For more information, go to the link below. - https://github.com/cli/gh-extension-precompile/releases/tag/v1.2.0 - cli/gh-extension-precompile#28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this action attempts to create a new release with assets and falls back to uploading to an existing release. Even if the call to
gh release createfails, GitHub creates a draft release with assets attached.Example
In gabe565/gh-profile, I created release v1.1.0 in the web UI. The action runs and logs the following:
But a draft release is created:
This PR modifies this behavior by checking if a release exists first. If it does,
gh release uploadis called. Else,gh release createis called.