Update action path to work on windows #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the path to the action script was `${{ github.action_path }}`
which uses the native path format. On Windows machines this ends up
passing paths with `\` to bash, which bash tries to interpret as escape
characters. "c:\a\b" would get be interpreted as "c:ab".
Now the path replaces all instances of `\` with `/` to work with bash on
Windows. This assumes that `\` would never be used on other github
runners.
Solution was copied from actions/runner#1066
|
This run, https://github.com/speedyleion/gh-difftool/actions/runs/4033773125 resulted in the following when running on a windows runner Run D:\a\_actions\cli\gh-extension-precompile\v1/build_and_release.sh
D:\a\_temp\30533e1b-ddc7-4866-bdca-4b174a20c926.sh: line 1: D:a_actionscligh-extension-precompilev1/build_and_release.sh: No such file or directory
Error: Process completed with exit code 127.This run https://github.com/speedyleion/gh-difftool/actions/runs/4035182759 used my fork and branch to succeed on windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the path to the action script was
${{ github.action_path }}which uses the native path format. On Windows machines this ends up passing paths with\to bash, which bash tries to interpret as escape characters. "c:\a\b" would get interpreted as "c:ab".Now the path replaces all instances of
\with/to work with bash on Windows. This assumes that\would never be used on other github runners.Solution was copied from actions/runner#1066