-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options for token override, draft releases and supplying release tag #37
Conversation
Add option to create release for existing specific tag
Allow overriding `github.token` and creating draft release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manue1: Thank you for the contribution!
Would like to delve into a couple aspects of these changes a little more deeply. I appreciate however you can help me understand the improvement these bring 🙇
build_and_release.sh
Outdated
if [ -n "$GH_RELEASE_TAG" ]; then | ||
echo "invoking release tag override $GH_RELEASE_TAG" | ||
tag="$GH_RELEASE_TAG" | ||
elif [[ $GITHUB_REF = refs/tags/* ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manue1 : Could you elaborate on this approach versus deriving the tag from the reference? Is there an example you can share that showcases a concrete example and how others might benefit from this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a use case for an upcoming CLI extension where the code resides in one repo and has the built binaries published to another separate repo. (see workflow)
Our current plan is to trigger the release manually by dispatching the workflow since it would follow the GHES release window. Instead of creating a release tag in the source repo we'd therefore solely create the tag in the destination repo and GITHUB_REF
would therefore not be set when the workflow is run.
I'm also unsure if this is a use case that many others will benefit from. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for making the requested changes.
As part of the release of an upcoming CLI extension in which the built binary gets uploaded to a secondary repository instead of the one in which the code resides the following options were added:
draft
releasegithub_token
input parameter in order to allow using a token other thangithub.token