Fix android builds requiring external (cgo) linking, but cgo is not enabled

[BagToad]

Fixes #50

This PR proposes:

• Extension authors will opt-in to releasing to Android / releasing to Android will be optional in future gh-extension-precompile versions.
• Support for building and releasing to Android targets will be best effort but cannot block the release to platforms officially supported by gh core.
• Extensions using Go < 1.22 and wish to release to Android can continue to leverage older versions of gh-extension-precompile to avoid this new logic.
• New action inputs:
  • release_android
  • android_sdk_version
  • android_ndk_home
• These changes will prompt a version bump to gh-extension-precompile.

Building on Android and change details

We will set CGO_ENABLED=1 and CC=${ANDROID_NDK_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android${ANDROID_SDK_VERSION}-clang for Android architectures, if both release_android and android_sdk_version action inputs are provided. If release_android is enabled but android_sdk_version is not set, the action will fail.

The android_ndk_home action input is used if the ANDROID_NDK_HOME environment variable is not set. The $ANDROID_NDK_HOME environment variable will be set automatically on GitHub hosted runners.

When release_android is not set, the action will not attempt to build for Android targets, avoiding the Android specific requirements completely - this is the proposed default behavior.

I just want my extension to continue building for Android - what should I do?

Along with bumping the action version, modify your workflow that calls gh-extension-precompile to include at least release_android and android_sdk_version.

Example:

- uses: cli/gh-extension-precompile@v2
  with:
    release_android: true
    android_sdk_version: 30
    generate_attestations: true
    go_version_file: go.mod

If you are running the workflow on a self-hosted runner, you should confirm that either the ANDROID_NDK_HOME environment variable is set or that you provide the android_ndk_home action input.

Testing

Build and release no android [email protected]

• workflow run
• release & artifacts

Build and release with android [email protected]

• workflow run
• release & artifacts

[CleanCut]

👍🏻 This would help my use. I have no need of android builds in the first place.

In fact, I'd love it if you could opt-in or opt-out of all the platforms. I only need one.

[andyfeller]

These changes look good, however I think there's more we need to do here before merging it especially since this will be a breaking change (@v2)

[andyfeller]

99% there! everything is looking good with minor suggestions on docs; let me know if you feels strongly and let's knock this out today

[BagToad]

Thank you @andyfeller 🙏 I have committed your suggestions and it's ready for another review pass ✨

[andyfeller]

Sincere thanks for unblocking our Go extension developer community while putting significant efforts to verifying these changes within Android simulator ✨

After merging this PR, I believe the only things that remain are:

1. Tagging the repo with v2.0.0 tag + release, which will cause our GitHub Actions to create the v2 branch; for more info, see below

2. Updating the release notes within the v2 release to explain the breaking change and how users will get more information to adopt the latest changes

gh-extension-precompile/.github/workflows/release.yml

Lines 11 to 21 in ee3e4e5

	jobs:
	release:
	runs-on: ubuntu-latest
	steps:
	- name: Update major release branch
	env:
	GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
	run: |
	tag="${GITHUB_REF#refs/tags/}"
	major=${tag%%.*}
	gh api -X PATCH /repos/"$GITHUB_REPOSITORY"/git/refs/heads/"$major" -f sha="$GITHUB_SHA"

[Cinderella252]

Seems to work