Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated HCP container memory usage metric #725

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mukrishn
Copy link
Collaborator

@mukrishn mukrishn commented Oct 3, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Changed query for monitoring HCP pod usage, capture container memory usage from container_memory_working_set_bytes instead of container_memory_rss. OOM killer is watching the former to kill the process if it exceeds(only if resource limit is set), so it would be better to report working set metrics to know its actual usage, it does not include cache or swap.

This blog helps to understand it better other container metrics too.

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Signed-off-by: Murali Krishnasamy <[email protected]>
@openshift-ci openshift-ci bot requested review from chentex and morenod October 3, 2024 16:46
Copy link

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mukrishn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 3, 2024
Signed-off-by: Murali Krishnasamy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant