updated HCP container memory usage metric #725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Changed query for monitoring HCP pod usage, capture container memory usage from
container_memory_working_set_bytes
instead ofcontainer_memory_rss
. OOM killer is watching the former to kill the process if it exceeds(only if resourcelimit
is set), so it would be better to report working set metrics to know its actual usage, it does not include cache or swap.This blog helps to understand it better other container metrics too.
Related Tickets & Documents
Checklist before requesting a review
Testing