Updating linter version to v1.41 #237
Conversation
armfazh
changed the title
armfazh
force-pushed
the
updateGolangci_1.41
branch
from
cd24567
to
7c97843
Compare
Was this change made by the linter or did you make it manually? |
I manually changed the instances reported by linter as insecure. |
armfazh
force-pushed
the
updateGolangci_1.41
branch
from
7c97843
to
92a0ed0
Compare
| for i := 0; i < N; i++ { | ||
| p[i] = int16(mathRand.Intn(18*int(Q) - 9*int(Q))) | ||
| p[i] = int16(int32(r[i] % max)) |
There was a problem hiding this comment.
This change looks equivalent to me. However, the way the original code was written is weird. (Why 18 * int(Q) - 9 * int(Q) instead of just 9 * int(Q)?) This makes me think it might be worth double checking that this is the correct range.
There was a problem hiding this comment.
@bwesterb could you please give us some light here?
There was a problem hiding this comment.
let's move this change forward, and do changes in other PR if bwesterb thinks it's needed.
There was a problem hiding this comment.
The intended code was int16(mathRand.Intn(9*int(Q)) - mathRand.Intn(18*int(Q))).
There was a problem hiding this comment.
Thanks Bas, I will fix this on #240
armfazh
force-pushed
the
updateGolangci_1.41
branch
from
c80bce5
to
0e53b81
Compare
Bumping up golangci-lint version to v1.41