Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: playground wip #231

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lbendavid-cloudinary
Copy link
Contributor

Pull request for cloudinary/frontend-frameworks

For which package is this PR?

all

What does this PR solve?

Adding the playground to Lerna so the libraries will be symlinked into them

Final checklist

  • Implementation is aligned to Spec.
  • Tests - Add proper tests to the added code.
  • Relates to a github issue (link to issue).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! I didn't know about this as a solution. No more relative dependencies in the playgrounds needed?

@lbendavid-cloudinary
Copy link
Contributor Author

It is not the final solution, because in order to use playground you will still need to build the package before.
This is due to how the packages are structured and their build process.
But this will allows you to run playground without install the package from npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants