Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support declaring individual efs, docker, fsx volumes for tasks #213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbcom
Copy link

@jbcom jbcom commented Nov 16, 2022

what

  • Supports declaring separate volumes for efs, docker, and fsx
  • This also decouples name and host_path which are expected to be passed uniquely in each volume variable declaration
  • Maintains backwards compatibility by pulling apart the deprecated volumes variable into the new expected format

why

  • terraform-aws-ecs-alb-service-task expects each of efs, docker, and fsx volumes to be passed separately
  • Also expects name and host_port to be declared in each of the volume variable declarations
  • Also allows for support for FSX volumes which are supported in the service-task module but not in this one.

references

@mihaiplesa
Copy link
Contributor

Is this ready to go? Seems like formatting failed.

@hans-d hans-d added wip Work in Progress: Not ready for final review or merge stale This PR has gone stale and removed wip Work in Progress: Not ready for final review or merge labels Mar 2, 2024
@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

@mergify mergify bot added triage Needs triage and removed stale This PR has gone stale labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants